Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Client certificate fingerprint not easily available #4758

Open
adamsong opened this issue Jun 30, 2023 · 6 comments
Open

Client certificate fingerprint not easily available #4758

adamsong opened this issue Jun 30, 2023 · 6 comments

Comments

@adamsong
Copy link

  • Node version: v18.16.1
  • Browser version: Firefox 114.0.2
  • Device, operating system: Windows 10
  • The Lounge version: v4.4.1

No simple way to view client cert fingerprints for SASL EXTERNAL auth. I get a nice message about doing /msg nickserv CERT ADD but no fingerprint is provided to give nickserv.

@adamsong adamsong added the Type: Bug Issues that report and PRs that solve any defects that cause unexpected behaviors. label Jun 30, 2023
@brunnre8
Copy link
Member

You normally don't need one, it'll default to the client cert you connected with.

We can't know what fp format is expected anyway (sha1, md5, sha256...) so even if we were to display it, that wouldn't help much.

What we do need is a way to do sasl plain AND certauth at the same time so that you don't have to manually identify to NS.

@brunnre8 brunnre8 removed the Type: Bug Issues that report and PRs that solve any defects that cause unexpected behaviors. label Jun 30, 2023
@adamsong
Copy link
Author

Any reason #4092 isn't just a separate checkbox?

@brunnre8
Copy link
Member

not particularly

@rpavlik
Copy link

rpavlik commented Aug 17, 2023

it appears as though OFTC doesn't support /msg nickserv CERT ADD without an explicit certificate fingerprint manually passed. Fortunately in that case, it echoes the certificate back to you during connection: https://www.oftc.net/NickServ/CertFP/#AddCertFPtoNS

@adamsong
Copy link
Author

The main issue is if I need to authenticate with SASL username/password then it won't send the cert at all, so there is no way to se the fingerprint. As a workaround I just modified my install to always send the cert

@chriscpritchard
Copy link

The main issue is if I need to authenticate with SASL username/password then it won't send the cert at all, so there is no way to se the fingerprint. As a workaround I just modified my install to always send the cert

This is the issue I have as well, it would be good to be able to have an option to always send the cert!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants