Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply user color to /me-actions #4741

Open
SimplyLinn opened this issue May 28, 2023 · 4 comments
Open

Apply user color to /me-actions #4741

SimplyLinn opened this issue May 28, 2023 · 4 comments

Comments

@SimplyLinn
Copy link

SimplyLinn commented May 28, 2023

Just want to get the color back in your client?

Go to the bottom of this issue, I put a workaround there.


EDIT NOTICE: This was originally phrased as a bug report. Seeing how this behavior came from a bugfix, I've restructured this original post as a feature request.

Feature Description

image

In the above screenshot, I've shown how it used to look in 4.3.X with the message I indicated, compared to how it looks with the current behavior.

This behavior got changed in the #4649 pull request that fixed CSS scoping issues, meaning that the original behavior was unintended. I do however quite prefer the original behavior and would at the very least enjoy it being a configurable option.

I do however agree with not having scoping issues in the CSS, so I don't suggest we go back to the previous implementation, but implement the previous behavior as an intentional feature.

WORKAROUND

First, make sure you have the latest version of The Lounge installed, and if you do and it's still not an available option, continue following these instructions.

Since there are 2 themes present in The Lounge, you need to pick the snipped meant for your theme. Default theme is the light mode, Morning theme is the dark/cyan mode.

Find the appropriate snippet and put it into Settings -> Appearance -> Custom Stylesheet

Remember to check whether this behavior has been reverted/reimplemented after you've updated The Lounge, and if so, remove the snippet from your Custom Stylesheets.

Default theme

#chat .msg[data-type="action"] .content .user { color: #50a656; }
#chat .msg[data-type="action"] .content .user.color-1 { color: #107ead; }
#chat .msg[data-type="action"] .content .user.color-2 { color: #a86500; }
#chat .msg[data-type="action"] .content .user.color-3 { color: #008a3c; }
#chat .msg[data-type="action"] .content .user.color-4 { color: #e00096; }
#chat .msg[data-type="action"] .content .user.color-5 { color: #f0000c; }
#chat .msg[data-type="action"] .content .user.color-6 { color: #000094; }
#chat .msg[data-type="action"] .content .user.color-7 { color: #006441; }
#chat .msg[data-type="action"] .content .user.color-8 { color: #00566e; }
#chat .msg[data-type="action"] .content .user.color-9 { color: #e6006b; }
#chat .msg[data-type="action"] .content .user.color-10 { color: #0d8766; }
#chat .msg[data-type="action"] .content .user.color-11 { color: #006b3b; }
#chat .msg[data-type="action"] .content .user.color-12 { color: #00857e; }
#chat .msg[data-type="action"] .content .user.color-13 { color: #00465b; }
#chat .msg[data-type="action"] .content .user.color-14 { color: #eb005a; }
#chat .msg[data-type="action"] .content .user.color-15 { color: #e62600; }
#chat .msg[data-type="action"] .content .user.color-16 { color: #0f8546; }
#chat .msg[data-type="action"] .content .user.color-17 { color: #e60067; }
#chat .msg[data-type="action"] .content .user.color-18 { color: #eb002b; }
#chat .msg[data-type="action"] .content .user.color-19 { color: #eb003f; }
#chat .msg[data-type="action"] .content .user.color-20 { color: #007a56; }
#chat .msg[data-type="action"] .content .user.color-21 { color: #095092; }
#chat .msg[data-type="action"] .content .user.color-22 { color: #000bde; }
#chat .msg[data-type="action"] .content .user.color-23 { color: #008577; }
#chat .msg[data-type="action"] .content .user.color-24 { color: #00367d; }
#chat .msg[data-type="action"] .content .user.color-25 { color: #007e9e; }
#chat .msg[data-type="action"] .content .user.color-26 { color: #006119; }
#chat .msg[data-type="action"] .content .user.color-27 { color: #007ea8; }
#chat .msg[data-type="action"] .content .user.color-28 { color: #3c8500; }
#chat .msg[data-type="action"] .content .user.color-29 { color: #e6007e; }
#chat .msg[data-type="action"] .content .user.color-30 { color: #c75300; }
#chat .msg[data-type="action"] .content .user.color-31 { color: #eb0400; }
#chat .msg[data-type="action"] .content .user.color-32 { color: #e60082; }

Morning theme:

#chat .msg[data-type="action"] .content .user { color: #b0bacf; }
#chat .msg[data-type="action"] .content .user.color-1 { color: #f7adf7; }
#chat .msg[data-type="action"] .content .user.color-2 { color: #abf99f; }
#chat .msg[data-type="action"] .content .user.color-3 { color: #86efdc; }
#chat .msg[data-type="action"] .content .user.color-4 { color: #c890eb; }
#chat .msg[data-type="action"] .content .user.color-5 { color: #f9a4b3; }
#chat .msg[data-type="action"] .content .user.color-6 { color: #f7999a; }
#chat .msg[data-type="action"] .content .user.color-7 { color: #f497b9; }
#chat .msg[data-type="action"] .content .user.color-8 { color: #f9a9d7; }
#chat .msg[data-type="action"] .content .user.color-9 { color: #85a7e3; }
#chat .msg[data-type="action"] .content .user.color-10 { color: #a8b8ff; }
#chat .msg[data-type="action"] .content .user.color-11 { color: #b695fc; }
#chat .msg[data-type="action"] .content .user.color-12 { color: #f4aead; }
#chat .msg[data-type="action"] .content .user.color-13 { color: #fc7cb1; }
#chat .msg[data-type="action"] .content .user.color-14 { color: #ff72e0; }
#chat .msg[data-type="action"] .content .user.color-15 { color: #8cb6ea; }
#chat .msg[data-type="action"] .content .user.color-16 { color: #f9857c; }
#chat .msg[data-type="action"] .content .user.color-17 { color: #ed9b82; }
#chat .msg[data-type="action"] .content .user.color-18 { color: #8df484; }
#chat .msg[data-type="action"] .content .user.color-19 { color: #ffcce3; }
#chat .msg[data-type="action"] .content .user.color-20 { color: #efcc81; }
#chat .msg[data-type="action"] .content .user.color-21 { color: #92a2ed; }
#chat .msg[data-type="action"] .content .user.color-22 { color: #f4d484; }
#chat .msg[data-type="action"] .content .user.color-23 { color: #97ea70; }
#chat .msg[data-type="action"] .content .user.color-24 { color: #fcbbba; }
#chat .msg[data-type="action"] .content .user.color-25 { color: #eef975; }
#chat .msg[data-type="action"] .content .user.color-26 { color: #c7ff93; }
#chat .msg[data-type="action"] .content .user.color-27 { color: #ffade1; }
#chat .msg[data-type="action"] .content .user.color-28 { color: #98ecf2; }
#chat .msg[data-type="action"] .content .user.color-29 { color: #91a2f5; }
#chat .msg[data-type="action"] .content .user.color-30 { color: #b19aea; }
#chat .msg[data-type="action"] .content .user.color-31 { color: #f2a4eb; }
#chat .msg[data-type="action"] .content .user.color-32 { color: #85f27d; }
@SimplyLinn SimplyLinn added the Type: Bug Issues that report and PRs that solve any defects that cause unexpected behaviors. label May 28, 2023
@brunnre8
Copy link
Member

brunnre8 commented May 28, 2023

That's from my css scope PR

technically this is a bug fix, as you already alluded to this is intended by the CSS given in the default themes.

Now, do I like it? Not really.
I'd agree with you that nick colors in action messages would be nice to have.

Not sure why the original author did that.

Consider this my vote, without having the maintainer hat on.

Let's wait and see what the opinions of the others are.

@brunnre8 brunnre8 removed the Type: Bug Issues that report and PRs that solve any defects that cause unexpected behaviors. label May 28, 2023
@SimplyLinn SimplyLinn changed the title User color not applied to /me-actions Apply user color to /me-actions May 28, 2023
@SimplyLinn
Copy link
Author

SimplyLinn commented May 28, 2023

@brunnre8 Ah, thank you! I missed that during my skim of the changelog. I have restructured the original post into a feature request to anchor the discussion with the context of adding a feature.

@kohlrak
Copy link

kohlrak commented Mar 27, 2024

Let's wait and see what the opinions of the others are.

I don't know if by "the others" you mean maintainers or users, but here's my response: It might make it harder to see. Some sort of checkbox to automatically switch the tag between existing methods should be user preference. Both approaches are meant to improve readability and that's only something the end-user can know which they prefer.

@brunnre8
Copy link
Member

maintainers, technically.
But most of them have too many other things on their plate recently so don't hold your breath.

But no, it doesn't make it harder to see, generally helps picking up what context it refers to.

We definitely won't make this a checkbox if I have a say in it, TL is meant to be easy to use and lots of options go against that.

And of all things, there's more important ones we might have than this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants