New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Apply user color to /me-actions #4741
Comments
That's from my css scope PR technically this is a bug fix, as you already alluded to this is intended by the CSS given in the default themes. Now, do I like it? Not really. Not sure why the original author did that. Consider this my vote, without having the maintainer hat on. Let's wait and see what the opinions of the others are. |
@brunnre8 Ah, thank you! I missed that during my skim of the changelog. I have restructured the original post into a feature request to anchor the discussion with the context of adding a feature. |
I don't know if by "the others" you mean maintainers or users, but here's my response: It might make it harder to see. Some sort of checkbox to automatically switch the tag between existing methods should be user preference. Both approaches are meant to improve readability and that's only something the end-user can know which they prefer. |
maintainers, technically. But no, it doesn't make it harder to see, generally helps picking up what context it refers to. We definitely won't make this a checkbox if I have a say in it, TL is meant to be easy to use and lots of options go against that. And of all things, there's more important ones we might have than this. |
Just want to get the color back in your client?
Go to the bottom of this issue, I put a workaround there.
EDIT NOTICE: This was originally phrased as a bug report. Seeing how this behavior came from a bugfix, I've restructured this original post as a feature request.
Feature Description
In the above screenshot, I've shown how it used to look in 4.3.X with the message I indicated, compared to how it looks with the current behavior.
This behavior got changed in the #4649 pull request that fixed CSS scoping issues, meaning that the original behavior was unintended. I do however quite prefer the original behavior and would at the very least enjoy it being a configurable option.
I do however agree with not having scoping issues in the CSS, so I don't suggest we go back to the previous implementation, but implement the previous behavior as an intentional feature.
WORKAROUND
First, make sure you have the latest version of The Lounge installed, and if you do and it's still not an available option, continue following these instructions.
Since there are 2 themes present in The Lounge, you need to pick the snipped meant for your theme. Default theme is the light mode, Morning theme is the dark/cyan mode.
Find the appropriate snippet and put it into
Settings -> Appearance -> Custom Stylesheet
Remember to check whether this behavior has been reverted/reimplemented after you've updated The Lounge, and if so, remove the snippet from your Custom Stylesheets.
Default theme
Morning theme:
The text was updated successfully, but these errors were encountered: