Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sparse encoding #650

Open
Zethson opened this issue Feb 3, 2024 · 0 comments
Open

sparse encoding #650

Zethson opened this issue Feb 3, 2024 · 0 comments
Assignees
@eroell
Labels
enhancement New feature or request

Comments

@Zethson
Copy link
Member

Zethson commented Feb 3, 2024

Description of feature

I looked a bit into sparse encoding. One-hot encoding being the most important:

  1. scikit-learn's one-hot encoding supports a sparse_output parameter that should return a CSR matrix.
  2. We're getting original_values as numpy arrays when calling the function. May or may not be fine.
  3. Currently we default the sparse_output parameter to False without checking the type of matrix.
  4. The _update_encoded_data does not take sparse matrices into account
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eroell eroell

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Zethson @eroell