Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate Removing .params #148

Open
ilan-gold opened this issue Jul 28, 2022 · 0 comments
Open

Investigate Removing .params #148

ilan-gold opened this issue Jul 28, 2022 · 0 comments

Comments

@ilan-gold
Copy link
Collaborator

ilan-gold commented Jul 28, 2022

We should look into removing params as it is causing issues and is not necessary. If one needs the concatenation of the fitted parameters, then that should be a feature and not the default.

Specifically, the ModelContainer has setters for theta_location theta_scale that are quite slow because of having to update one .params dask array which is then recreated.

This should allow for theta_scale and theta_location to be optional (i.e for Poisson models)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant