Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make init_par a class Method #147

Open
ilan-gold opened this issue Jul 28, 2022 · 1 comment
Open

Make init_par a class Method #147

ilan-gold opened this issue Jul 28, 2022 · 1 comment

Comments

@ilan-gold
Copy link
Collaborator

Right now, initialization of the parameters occurs on a per-model basis but generally the function is quite similar across different models. This should become a class method.

@picciama
Copy link
Collaborator

picciama commented Aug 5, 2022

I don't necessarily agree, because it doesn't only depend on the model but also on the specific "flavour". edgeR for example uses some fancy QR decomposition stuff to initialise the location params, while the dispersion params are fixed to e.g. 0.05, which needs to be translated to our case, which is then np.log(1 / 0.05) over all features. Let's wait till the stuff from #145, is merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants