Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure everything is stopped/canceled on SIGINT #1146

Open
jason0x43 opened this issue Apr 21, 2020 · 0 comments
Open

Ensure everything is stopped/canceled on SIGINT #1146

jason0x43 opened this issue Apr 21, 2020 · 0 comments
Labels
bug Something that's not working as intended effort-medium This may take a couple of days priority-high Most important
Projects
Development

Comments

@jason0x43
Copy link
Member

Intern and digdug intercept SIGINT to allow for a graceful shutdown. Currently Intern's SIGINT handler just shuts down the server in serve-only mode. In normal testing mode Intern will still wait for the test task to finish.

Intern should handle SIGINT by cancelling any running tasks and explicitly stopping the test server, if it's running. If coverage is enabled, SIGINT should prevent any further coverage collection, such as for covered but uninstrumented files.
@jason0x43 jason0x43 added effort-medium This may take a couple of days priority-medium This should get done, but it's not a high priority labels Apr 21, 2020
@github-actions github-actions bot added this to To do in Development Apr 21, 2020
@jason0x43 jason0x43 added bug Something that's not working as intended priority-high Most important and removed priority-medium This should get done, but it's not a high priority labels Apr 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something that's not working as intended effort-medium This may take a couple of days priority-high Most important
Projects
Development
To do
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jason0x43