Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issues with self closing tag, space between start and end dag, and using {slot} inside component #23

Open
hleinan opened this issue May 6, 2024 · 1 comment

Comments

@hleinan
Copy link

hleinan commented May 6, 2024

Hey, and thanks for this static generator. I tried it yesterday and found a few annoying things that does not look quite right:

  • using self closing tag for include does not work
  • having a space between start and ende include tag makes the component not render. If there are many attributes in a tag, it is useful to split it in multiple lines, and then it easily breaks, like this:
<include 
    src="message.html"
>
</include>
  • I found it really strange that an include cannot have a slot. Like:
<include src="message.html">Some content</include>
<!-- inside the include message.html above -->
<div>{slot}</div>

Also, using the content folder using markdown files does not seem to render as it should with auto url mapping. I tried the docs example on you website, but pages/index.html seems to be rendered anyway, but without a 404, so it looks like it finds the correct file. Just the rendering seems wrong

@tnylea
Copy link
Contributor

tnylea commented May 29, 2024

For sure! Glad you are getting some use out of it.

I would like to see the {slot} functionality in there as well. I'll definitely add it to our list, feel free to take a look at the code and submit a PR if possible.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants