Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Huge header image not reduced #17

Open
waldyrious opened this issue Dec 26, 2017 · 1 comment
Open

Huge header image not reduced #17

waldyrious opened this issue Dec 26, 2017 · 1 comment

Comments

@waldyrious
Copy link

I'm not sure whether this is a regression of #10 or simply a different markup that would need to be supported, but see for example https://articles.mattoakes.net/a-better-way-to-automatically-merge-changes-in-your-xcode-project-files-3d83b3583fe4 -- for me, the title image isn't reduced.

Perhaps it's a CSP issue? I'm seeing the following error in the console:

Content Security Policy: The page’s settings blocked the loading of a resource at data:application/javascript;base64,KGZ1b... (“script-src 'unsafe-eval' 'unsafe-inline' about: https: https://articles.mattoakes.net”).

@thebaer thebaer added the bug label Mar 5, 2018
@thebaer
Copy link
Owner

thebaer commented Mar 31, 2018

Doesn't seem to be a CSP issue -- rather it looks like this is a different type of giant image section that wasn't covered by #9 / #10. Notably this section contains text, whereas #10 covers giant standalone images like in this article.

I didn't find a quick solution and would want to do more testing to be sure there aren't side-effects. But anyone should feel free to try and fix this if they want.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants