Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cleanup] Add a findAllBySpaceId with a roles check #161

Closed
Kluskey opened this issue May 7, 2024 · 0 comments · Fixed by #170
Closed

[Cleanup] Add a findAllBySpaceId with a roles check #161

Kluskey opened this issue May 7, 2024 · 0 comments · Fixed by #170

Comments

@Kluskey
Copy link
Contributor

Kluskey commented May 7, 2024

Acceptance Criteria

  • This route should have a roles check, so duplicate it as /space-object/space-v2/:id and add the role check:
    @Get('space/:id')
    @ApiParam({ name: 'id', type: 'string', required: true })
    public async findAllBySpaceId(@Param('id') spaceId: SpaceId) {
    if (!spaceId || spaceId == 'undefined') {
    throw new BadRequestException('Invalid spaceId')
    }
    return await this.spaceObjectService.findAllBySpaceIdAdmin(spaceId)
    }
  • Add a @deprecated JSDoc onto the original /space-object/space/:id; we'll remove it once we update the client
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants