Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Incompatible Python and NumPy Versioning #22

Open
kamcbk opened this issue Nov 22, 2022 · 3 comments
Open

[BUG] Incompatible Python and NumPy Versioning #22

kamcbk opened this issue Nov 22, 2022 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@kamcbk
Copy link

kamcbk commented Nov 22, 2022

Heads up that numpy >=1.20.0 doesn't support Python 3.6. numpy.typing in merger.py was introduced in numpy 1.20.0. Tiler has been failing on any Python 3.6 work I try doing.

The two solutions I see are to remove numpy.typing to allow Python 3.6 to work or update tiler to work 3.7 =<.

@kamcbk kamcbk added the bug Something isn't working label Nov 22, 2022
@the-lay
Copy link
Owner

the-lay commented Nov 22, 2022

Thank you very much for the bug report!

Python 3.6 is already considered outdated, so the easy solution is to update the minimum required version to 3.7. Even some third-party numpy typing modules like nptyping don't support 3.6. However, since that is the only thing blocking tiler on py3.6, I will see what I can do to make it work.

@the-lay the-lay self-assigned this Nov 22, 2022
@kamcbk
Copy link
Author

kamcbk commented Nov 23, 2022

Up to you on whatever versioning you wish to support - I'll adapt accordingly. I would default to whatever Python versions are being supported by the rest of the Python community. A change in requirements, like you mentioned, would be the easiest solution. But it's all your choice.

Figured new users or anyone using older software would be looking at requirements a little more closer.

@cwerner
Copy link

cwerner commented Mar 14, 2023

FWIW: I also had to fork and remove the nptyping code from merger since my environment is pinned to numpy <1.2 due to other packages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants