Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to add "synthesis information" to starting materials #717

Open
jdbocarsly opened this issue Apr 25, 2024 · 3 comments
Open

Ability to add "synthesis information" to starting materials #717

jdbocarsly opened this issue Apr 25, 2024 · 3 comments
Labels
enhancement New feature or request webapp For issues/PRs pertaining to the web interface

Comments

@jdbocarsly
Copy link
Member

Currently, the Starting Material edit page doesn't have a synthesis information section. This is ussually fine, since the starting materials are purchased from a supplier and don't have any constituents that they need to be linked to. However, we sometimes may make a starting material in the lab, and want to link it to its constituents. In this case, it would be nice to have an optional synthesis information that can be added to starting materials pages if needed.

@jdbocarsly jdbocarsly added enhancement New feature or request webapp For issues/PRs pertaining to the web interface labels Apr 25, 2024
@MJCliffe
Copy link

Is there any reason not to make the starting material a sample itself?

@ml-evs
Copy link
Member

ml-evs commented May 17, 2024

They behave similarly but have different default permissions; e.g., you can use a sample wherever you would normally use a starting material (in recipes etc.), but you would lose some of the structure info about barcodes/hazards etc. A starting material also has the option to refer to the abstract concept of a material (e.g., water) rather than a particular instance (a glass of water) [showing my chemistry knowledge here].

@MJCliffe
Copy link

Ok - fair enough. I guess if you're making it, most of the time it won't have a SDS and you won't be having it as a generic, but if there are advantages the extra flexibility seems reasonable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request webapp For issues/PRs pertaining to the web interface
Projects
None yet
Development

No branches or pull requests

3 participants