Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better mobile support #620

Open
ml-evs opened this issue Feb 27, 2024 · 1 comment
Open

Better mobile support #620

ml-evs opened this issue Feb 27, 2024 · 1 comment
Labels
suggestions webapp For issues/PRs pertaining to the web interface

Comments

@ml-evs
Copy link
Member

ml-evs commented Feb 27, 2024

Again, from discussions with @veronika-sedajova! I tried out datalab on my phone with some pretty big echem data. It actually performs remarkably well (comparable speed to the desktop browser given how much is done server-side) but some of the UI gets pretty messed up in narrow screens (e.g., the top bar on the edit page).

Testing this would be a whole can of worms but we might be able to get 80% of the way there by just adjusting bootstrap classes to allow people to view things on their phones.

@ml-evs ml-evs added webapp For issues/PRs pertaining to the web interface suggestions labels Feb 27, 2024
@jdbocarsly
Copy link
Member

The boostrap classes are set up mostly reasonably since #566. The main outstanding issues on mobile responsiveness (that I am aware of) are:

  1. The table in CompactConstituentTable.vue uses fixed pixel widths, fixed at 600px. This causes weird things, like a horizontal scroll on phones. This should be made responsive.
  2. The EditPage navbar could probably have its options collapsed for small screen sizes, though we have avoided this because we aren't using bootstrap js right now because of our version of bootstrap. If we update bootstrap to v5 (Update to Bootstrap 5  #32), then this would be pretty straightforward. It would also probably be pretty easy to implement ourselves in vue.
  3. The sample table (and cell table, etc.) doesn't scale either. The fancy sample table in "next" works a bit better, though its still hard to read and we should probably hide most of the columns to improve readability
  4. The bokeh plots get very small on phone. some of the margins and styling could be adjusted to make it easier to see the data.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
suggestions webapp For issues/PRs pertaining to the web interface
Projects
None yet
Development

No branches or pull requests

2 participants