Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

peerDependency version messes up devDependency version update #38

Open
iiroj opened this issue Dec 30, 2019 · 0 comments
Open

peerDependency version messes up devDependency version update #38

iiroj opened this issue Dec 30, 2019 · 0 comments

Comments

@iiroj
Copy link

iiroj commented Dec 30, 2019

In my package I specify a peer dependency to a React version:

{
    "peerDependencies": {
        "react": ">=16.3"
    }
}

For development I've also installed React as a dev dependency:

{
    "devDependencies": {
        "react": "16.11.0"
    }
}

Now, when I run npm-upgrade it suggest bumping the devDependencies React to >=16.12 instead of 16.12.0.

In my opinion, it should always respect the scheme of the version to be bumped, instead of in this case using the scheme from peerDependencies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant