v6.3.2: Fix a deployment directory leak #1793
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e server I'll say this fixes #1779, but we'll have to see
Cyberboss
added
Fix
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #1793 +/- ##
=======================================
Coverage 95.50% 95.50%
=======================================
Files 679 679
Lines 145950 145970 +20
Branches 3173 3172 -1
=======================================
+ Hits 139385 139413 +28
+ Misses 6078 6070 -8
Partials 487 487 |
Cyberboss
force-pushed
the
TheHuntForRedOctober
branch
from
f609818
to
6d58ff6
Compare
Cyberboss
force-pushed
the
TheHuntForRedOctober
branch
from
6d58ff6
to
660b549
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🆑
Fixed an issue where stopping or rebooting the server could cause the previously used deployment directory to not properly get cleaned up.
/🆑
Also adds a bunch of logging to help detect the issue in the future.
Potentially fixes #1779
Mergine with
[TGSDeploy]