Prs fixes #106
Closed
Prs fixes #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove option to hide force reset - Changed stopped wording to cancelled in jobs
alexkar598
reviewed
Sep 27, 2022
Comment on lines
118
to
122
| if (prs.code === StatusCode.ERROR) { | ||
| addError(errorState, prs.error); | ||
| setPRs(PRs ?? []); | ||
| } else { | ||
| setPRs(prs.payload); |
There was a problem hiding this comment.
Problem is you still cant remove any prs with this
There was a problem hiding this comment.
Wouldn't your change fix that?
There was a problem hiding this comment.
Negative, the PR list cannot be displayed without info from github and without a pr list, you can see or interact with merged PRs
There was a problem hiding this comment.
the PR list cannot be displayed without info from github
We really need to change that so it can work with the existing test merge list
|
Actually I'll leave this open as a reminder to myself to do that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the commits
Fixes #102