Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Negative max-results yields an out of bound #32

Closed
bschaatsbergen opened this issue Mar 8, 2024 · 1 comment · Fixed by #33
Closed

Negative max-results yields an out of bound #32

bschaatsbergen opened this issue Mar 8, 2024 · 1 comment · Fixed by #33

Comments

@bschaatsbergen
Copy link
Member

bschaatsbergen commented Mar 8, 2024 •
edited

When specifying a value for --max-results that's negative, an unhandled exception will pop up:
panic: runtime error: slice bounds out of range [:-1]

This could be solved by using a PreRun/Check to check the value of the flag.
@ChrisTerBeke
Copy link
Collaborator

This tool is literally unusable 😑

@mmourick mmourick mentioned this issue Mar 9, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Don't allow negative value to be passed for --max-results flag tfversion/tfversion
2 participants
@ChrisTerBeke @bschaatsbergen