Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to npm 8+ #989

Closed
7 tasks
azu opened this issue Jan 10, 2023 · 0 comments · Fixed by #1020
Closed
7 tasks

Move to npm 8+ #989

azu opened this issue Jan 10, 2023 · 0 comments · Fixed by #1020
Labels
Status: PR Welcome Welcome to Pull Request Type: Maintenance Repository Maintenance Type: Meta Type: Meta - Related to repository itself

Comments

@azu
Copy link
Member

azu commented Jan 10, 2023

yarn v1 fails at sometimes.
#988 (comment)
We have used cache, but yarn fail to fetch

cache: 'yarn'

Yarn v1 will not fix these issues.

We can move to npm 8+. Now is the time.

TODO

  • remove yarn.lock
  • add package-lock.json
  • change lerna.json to npm
    • textlint/lerna.json

      Lines 3 to 6 in ca4fda9

      "npmClient": "yarn",
      "useWorkspaces": true,
      "packages": ["packages/*", "examples/*", "packages/@textlint/*", "test/integration-test", "website"],
      "includeMergedTags": true,
  • Replace yarn to npm command in CI and scripts ant netlify.yml etc...
  • Rewrite CONTRIBUTING.md

Test Plans

  • Pass CI
  • grep yarn
    • rg is useful
@azu azu added Type: Maintenance Repository Maintenance Status: PR Welcome Welcome to Pull Request Type: Meta Type: Meta - Related to repository itself labels Jan 10, 2023
@azu azu mentioned this issue Jan 25, 2023
2 tasks
@azu azu linked a pull request Jan 28, 2023 that will close this issue
@azu azu closed this as completed in #1020 Jan 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: PR Welcome Welcome to Pull Request Type: Maintenance Repository Maintenance Type: Meta Type: Meta - Related to repository itself
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant