Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hub gateway doesn't support HTTP Range queries #560

Open
carsonfarmer opened this issue Jun 16, 2021 · 1 comment
Open

Hub gateway doesn't support HTTP Range queries #560

carsonfarmer opened this issue Jun 16, 2021 · 1 comment
Labels
bug Something isn't working enhancement New feature or request
Projects

Comments

@carsonfarmer
Copy link
Member

The default IPFS gateway's support this HTTP header, which is pretty much required for serving video content. Currently, our gateway does not. In fact, browser apps get a CORS error on preflight requests because we don't support this header. Is there an easy path to supporting Range Queries?

Screen Shot 2021-06-15 at 4 14 20 PM

cc @sanderpick

@carsonfarmer carsonfarmer added bug Something isn't working enhancement New feature or request labels Jun 16, 2021
@carsonfarmer carsonfarmer added this to To do in Textile via automation Jun 16, 2021
@carsonfarmer
Copy link
Member Author

There are essentially two components to this issue. One is simply allowing HTTP Range headers in the first place, and the second is then actually supporting partial requests and range queries. The default IPFS gateway uses the built in Golang http.serveContent() method, which should be properly parsing Range HTTP headers and only returns the content in the range the client requested, so we would likely have to do something similar, or support Range HTTP headers directly ourselves.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
Textile
  
To do
Development

No branches or pull requests

1 participant