-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better names for functions ending in _custom()
#11
Comments
An idea is to use guidance_* instead of guide_* for all of your guides. E.g. guidance_colourbar() I presume all of your guides will act in a similar way with args etc. So then I think it's useful to the user for it to be obvious as to whether the guide is from gguidance or ggplot2. Also, I think "guid" with autocomplete would give all ggplot2 and gguidance guides, and "guida" would give just gguidance guides. That'd be nice! Don't know your r package well enough to know if this would be internally consistent with how everything else is named though.. Another idea you've prob throught of is to use 2 instead of custom in the name. Good luck! Naming is hard |
I like the idea of using a |
Ah damn, didn't think of that... Only other idea is a play on words. But would need to be misspelt unfortunately..
Not sure whether this is good or not. The strings look a little weird. But it's another idea anyway |
Maybe the above is too weird. If you use a word in your guide names like 'custom', I think you should consider applying it to all of your guides - given that they will all operate with this custom-ness/flexibility - and this would identify them as being from your package. Other ideas for this word are flexible, flex, flexi, ply, plyr or plie.. |
What about adding a "d":
Probably too crazy and too long, but easy to remember. |
I like the |
I'm discontent with the name of some function that end in the
_custom()
suffix.Famously, naming things is one of the harder things to do in programming.
I'd gladly entertain alternative names for these.
Currently, it concerns the following functions:
guide_axis_custom()
guide_colourbar_custom()
guide_coloursteps_custom()
The text was updated successfully, but these errors were encountered: