Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Add warnings when globals aren't injected #1257

Open
MatanBobi opened this issue Nov 26, 2023 · 0 comments
Open

[Feature Request] Add warnings when globals aren't injected #1257

MatanBobi opened this issue Nov 26, 2023 · 0 comments

Comments

@MatanBobi
Copy link
Member

MatanBobi commented Nov 26, 2023

Describe the feature you'd like:

As a followup to #1240.
If a user isn't injecting globals (like in vitest), they need to call cleanup on their own and also set the REACT_IS_ACT_ENVIRONMENT. In case they aren't doing that, we should warn them because this will break the behavior.

Suggested implementation:

We can log a warning in case globals aren't injected, but this won't cover the option where users can call cleanup on their own.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant