Skip to content
This repository has been archived by the owner on Sep 6, 2023. It is now read-only.

Ability to filter tests that didn't use puppeteer from root-cause ls #28

Open
benjamingr opened this issue Sep 23, 2020 · 3 comments
Open
Labels
enhancement New feature or request

Comments

@benjamingr
Copy link
Contributor

Currently even tests that had no actions are shown in root-cause ls

Reported by @talkl

@benjamingr benjamingr added the enhancement New feature or request label Sep 23, 2020
@Bnaya
Copy link
Contributor

Bnaya commented Sep 23, 2020

This is because there's attach call and testEnd calls,
so result folder is create for the test under that run.

We can in some point ignore if there are 0 steps, But we need to think what do to on test failure

@benjamingr
Copy link
Contributor Author

We can in some point ignore if there are 0 steps, But we need to think what do to on test failure

We should, and it also creates an issue in root-cause cloud

@gioragutt
Copy link
Contributor

gioragutt commented Oct 10, 2020

This is because there's attach call and testEnd calls,
so result folder is create for the test under that run.

We can in some point ignore if there are 0 steps, But we need to think what do to on test failure

@Bnaya There can be a beforeEach hook, that turns some boolean in TestContext to true.
If this flag is true, this means that at least one step started, so we know there is something to report,
Even if the first step failed and whole test failed following it.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants