Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rails 7.1 Support Question #9

Open
thewatts opened this issue Oct 13, 2023 · 5 comments
Open

Rails 7.1 Support Question #9

thewatts opened this issue Oct 13, 2023 · 5 comments

Comments

@thewatts
Copy link
Contributor

👋 Hey there!

Love all the OSS work that Test Double does - and all of the thought leadership that comes out of the crew.

I was working with a project to update it to 7.1, and the project uses this gem (and it's very helpful!)

I found the issue at hand, specifically - ActiveRecord::InternalMetadata no longer inherits from ActiveRecord::Base: rails/rails@93ddf33

Not a difficult fix - but I suppose I'm curious if this project is still something actively used by the Test Double team.

If this isn't the recommended path anymore - totally fine, and I'd love to know what the team prefers. If it is, however, I'm more than happy to submit a PR.

Thanks again for all you do!

thewatts added a commit to BenchmarkWine/test_data that referenced this issue Oct 28, 2023
ActiveRecord::InternalMetadata no longer inherits from ActiveRecord::Base: rails/rails@93ddf33

Reference: testdouble#9
@simi
Copy link

simi commented Nov 1, 2023

@thewatts any plans to open PR? I have checked and your update works well for our project. Btw. I'm also enjoying using this gem 💪.

@radglob
Copy link
Collaborator

radglob commented Jan 19, 2024

Hey @thewatts, I've taken over ownership of this gem. Definitely looking into what it will take to have support for Rails 7.1. The changes to ActiveRecord::InternalMetadata are definitely an issue I've run into as well.

If you'd like to make a PR addressing those changes, that would be greatly appreciated. Otherwise, it's something I'm hoping to take care of soon.

infews added a commit to infews/test_data that referenced this issue Feb 5, 2024
infews added a commit to infews/test_data that referenced this issue Feb 5, 2024
@infews
Copy link

infews commented Feb 5, 2024

PR #12 - 3a1b605 fixes this for 7.1 - but probably won't work with earlier versions.

@thewatts
Copy link
Contributor Author

thewatts commented Feb 6, 2024

Hey @thewatts, I've taken over ownership of this gem. Definitely looking into what it will take to have support for Rails 7.1. The changes to ActiveRecord::InternalMetadata are definitely an issue I've run into as well.

If you'd like to make a PR addressing those changes, that would be greatly appreciated. Otherwise, it's something I'm hoping to take care of soon.

Hey there!

Sorry - I didn't see the notification about your message!

I don't mind taking my code and submitting a PR :)

Hold tight

@thewatts
Copy link
Contributor Author

thewatts commented Feb 6, 2024

@infews added here: #14

thewatts added a commit to BenchmarkWine/test_data that referenced this issue Feb 6, 2024
ActiveRecord::InternalMetadata no longer inherits from ActiveRecord::Base: rails/rails@93ddf33

Reference: testdouble#9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants