Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement]: Make ingest.geoip.downloader.enabled environment of elastic container optional #1174

Open
xzxzxc opened this issue May 10, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@xzxzxc
Copy link

xzxzxc commented May 10, 2024

Problem

Not all elastic images are compatible with the ingest.geoip.downloader.enabled environment. We use a custom image which produces the following error

unknown setting [ingest.geoip.downloader.enabled] please check that any required plugins are installed, or check the breaking changes documentation for removed settings

Solution

Add an option in the constructor of ElasticsearchContainer, or a separate method, to prevent setting the ingest.geoip.downloader.enabled environment.

Benefit

A broader range of custom elastic images will be supported.

Alternatives

For now, we use the following workaround

.WithEnvironment("ingest.geoip.downloader.enabled", "")

Would you like to help contributing this enhancement?

Yes

@xzxzxc xzxzxc added the enhancement New feature or request label May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant