Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

model misidentification #3565

Open
1 task done
pezbailarin opened this issue Dec 14, 2023 · 11 comments
Open
1 task done

model misidentification #3565

pezbailarin opened this issue Dec 14, 2023 · 11 comments
Labels
area:tesla api Related to the Tesla API area:teslamate Related to TeslaMate core note:more information needed The reporter has to provide more information undetermined Not sure if this is considered a real bug

Comments

@pezbailarin
Copy link

Is there an existing issue for this?

  • I have searched the existing issues

What happened?

I have a 2024 Model 3 (highland) but teslamate thinks it's a model 3+ instead.

Expected Behavior

Correctly identify the kind of model 3.

Steps To Reproduce

  1. Have a model 3 highland
  2. setup teslamate for it

Relevant log output

No relevant log.

Screenshots

No response

Additional data

No response

Type of installation

Docker

Version

v1.28.2

@cwanja
Copy link
Collaborator

cwanja commented Dec 14, 2023

What is stored in your cars table, removing the VIN?

What shows on the TeslaMate home page?

@NirKli
Copy link
Contributor

NirKli commented Dec 15, 2023

Are you referring to the trim badge displayed in the TeslaMate UI?

@cwanja
Copy link
Collaborator

cwanja commented Dec 15, 2023

Are you referring to the trim badge displayed in the TeslaMate UI?

Yes. As well as what is in the database.

@NirKli
Copy link
Contributor

NirKli commented Dec 15, 2023

Are you referring to the trim badge displayed in the TeslaMate UI?

Yes. As well as what is in the database.

Understood. Since the trim badge data is sourced from the Tesla API, it's possible that Tesla labels this model in that particular way. We can investigate further to see if there's a discrepancy between Tesla's API data and the actual model specifics.

@pezbailarin
Copy link
Author

This is my "cars" table, including the VIN. Sorry for the bad formatting.

id | eid | vid | model | efficiency | inserted_at | updated_at | vin | name | trim_badging | set
tings_id | exterior_color | spoiler_type | wheel_type | display_priority | marketing_name
----+-----------------+------------------+-------+------------+---------------------+---------------------+-------------------+--------------+--------------+----
---------+----------------+--------------+------------+------------------+----------------
1 | 929884241727749 | 1689304849517060 | 3 | 0.143 | 2023-12-12 19:02:18 | 2023-12-17 12:35:58 | LRW3E7FS7RC963406 | 10.000 Gauss | 50 |
1 | PearlWhite | None | Glider18 | 1 | SR+

@cwanja
Copy link
Collaborator

cwanja commented Dec 18, 2023

3 & 50 & SR+

Those attributes are the reason TeslaMate is displaying Model 3 SR+. You can see that in the marketing_name.

Current code looks at the model and marketing_name. Anyone with a non-Model 3 Highland share their cars table? My guess is it will be the same (looking at TeslaMate code), thus not able to differentiate between a Highland and non-Highland.

@pezbailarin
Copy link
Author

I see. I didn't know if that was directly read from my car or somehow decoded from VIN. Well, thanks for taking a look, maybe I have a SR+ after all!

@cwanja
Copy link
Collaborator

cwanja commented Dec 18, 2023

I see. I didn't know if that was directly read from my car or somehow decoded from VIN. Well, thanks for taking a look, maybe I have a SR+ after all!

It is pulled directly from the API. If you are comfortable making API calls, you could pull your vehicle_data from the API and confirm what comes from Tesla.

https://www.teslaapi.io/vehicles/state-and-settings

@pezbailarin
Copy link
Author

Definitely beyond my skills. Already took a while to learn enough to understand what a "cars" table is, and how to retrieve it:)

@JakobLichterfeld JakobLichterfeld added area:teslamate Related to TeslaMate core area:tesla api Related to the Tesla API undetermined Not sure if this is considered a real bug note:more information needed The reporter has to provide more information labels Dec 19, 2023
@DominikK0702
Copy link

Here i have the 'cars' table with a model 3 highland and a model y.

id eid vid model efficiency inserted_at updated_at vin name trim_badging settings_id exterior_color spoiler_type wheel_type display_priority marketing_name
2 9297092945XXXXX 1689XXXXXXXXXX Y 1702902957000 1702902958000 LRWYXXXXXXXXXXX 74D 2 MidnightSilver None Induction20Black 1 LR AWD
1 9298844120XXXXX 1689XXXXXXXXXX 3 1702902957000 1702904712000 LRW3XXXXXXXXXXX 74D 1 StealthGrey None Glider18 1 LR AWD

@cwanja
Copy link
Collaborator

cwanja commented Dec 28, 2023

Here i have the 'cars' table with a model 3 highland and a model y.

id eid vid model efficiency inserted_at updated_at vin name trim_badging settings_id exterior_color spoiler_type wheel_type display_priority marketing_name
2 9297092945XXXXX 1689XXXXXXXXXX Y 1702902957000 1702902958000 LRWYXXXXXXXXXXX 74D 2 MidnightSilver None Induction20Black 1 LR AWD
1 9298844120XXXXX 1689XXXXXXXXXX 3 1702902957000 1702904712000 LRW3XXXXXXXXXXX 74D 1 StealthGrey None Glider18 1 LR AWD

This adds more confusion in that yours is referenced as a LR AWD Model 3 Highland. Based upon this, there is not yet a way to designate a Highland Model 3 from the API.

Still interested if either of you could pull your vehicle_data to see what the API returns.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:tesla api Related to the Tesla API area:teslamate Related to TeslaMate core note:more information needed The reporter has to provide more information undetermined Not sure if this is considered a real bug
Projects
None yet
Development

No branches or pull requests

5 participants