Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tala improvement suggestion: reduce empty space #27

Open
judepayne opened this issue Jan 27, 2023 · 5 comments
Open

Tala improvement suggestion: reduce empty space #27

judepayne opened this issue Jan 27, 2023 · 5 comments

Comments

@judepayne
Copy link

Hi,
On large diagrams, Tala introduces quite a lot of empty space.
Would it be possible to introduce a setting to 'compress' the space?

image

@alixander alixander transferred this issue from terrastruct/d2 Feb 1, 2023
@alixander
Copy link
Contributor

most recent TALA release has an improvement related to this. can you try rerunning? (or post the script if it's still bad) @judepayne

@judepayne
Copy link
Author

Thanks @alixander I have played with this and large diagrams like above that previously could have too much space, now have a lot less and look a lot better!

@judepayne judepayne reopened this Feb 1, 2023
@judepayne
Copy link
Author

Hi @alixander I closed this but just experimenting with generating random graphs and here's another one that seems to create a lot more empty space than strictly required:

bank: {
Funds: {
app8167: Data Source
app8169: Flame minor
app8171: Trade propel
}
Risk: {
app8164: Credit guard
}
Fixed Income: {
app8166: Data Source
app8170: Data Source
}
Corporate: {
app8168: Risk Sheet
app8172: Apac Ace
}
Equities: {
app8165: Book down
}
Finance: {
app8173: Zone out
}
}
bank.Corporate.app8168 -> bank.Corporate.app8168: client master
bank.Risk.app8164 -> bank.Corporate.app8172: allocations
bank.Risk.app8164 -> bank.Funds.app8169: instructions
bank.Risk.app8164 -> bank.Corporate.app8168: trades
bank.Funds.app8171 -> bank.Fixed Income.app8166: instructions
bank.Risk.app8164 -> bank.Risk.app8164: client master
bank.Funds.app8169 -> bank.Funds.app8167: instructions
bank.Fixed Income.app8170 -> bank.Corporate.app8172: positions
bank.Fixed Income.app8170 -> bank.Funds.app8167: security reference
bank.Fixed Income.app8170 -> bank.Fixed Income.app8166: instructions
bank.Funds.app8171 -> bank.Equities.app8165: positions
bank.Funds.app8171 -> bank.Funds.app8171: positions

@alixander
Copy link
Contributor

@gavin-ts i think our parameters just considers this okay. e.g. grid cell is large because of the containers. i suspect if we just lower the threshold it'll be okay

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

3 participants