We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
I believe the only functional solution would be something like:
context.py
armi.context.PLATFORM
The goal here is to remove a ton of existing (and future) duplicate catches all around ARMI:
if "win" in sys.platform: # this elif "linux" in sys.platform: # that else: raise OSError("xyz")
Instead we can do:
if PLATFORM == WINDOWS: # this else: # that
The text was updated successfully, but these errors were encountered:
safeCopy
import armi
An Enum / Flag might be nice for this versus a string!
Enum
Flag
Sorry, something went wrong.
We have a lot of mac users here despite it not being formally supported, it works well
Well, that's a wrench. Hmm
@drewejohnson I just tried to run the ARMI tests on MacOS and 18 of the 2064 tests failed:
https://github.com/terrapower/armi/actions/runs/8898351718/job/24435316299#step:5:2441
Most of the errors were of the form:
No such file or directory: 'refSmallReactor.yaml'
If that's an easy one to solve, maybe I could add MacOS to the official ARMI CI.
@drewejohnson Just FYI, I just opened a PR to support Macs: #1713
john-science
No branches or pull requests
I believe the only functional solution would be something like:
context.py
, at "import armi" time, ARMI should determine if this system is Window or Linux, and sets a global variable:armi.context.PLATFORM
.armi.context.PLATFORM
throughout the codebase.The goal here is to remove a ton of existing (and future) duplicate catches all around ARMI:
Instead we can do:
The text was updated successfully, but these errors were encountered: