Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Armi Half Life Data Error #1681

Open
tp-pbritt-nuc opened this issue Apr 4, 2024 · 2 comments
Open

Armi Half Life Data Error #1681

tp-pbritt-nuc opened this issue Apr 4, 2024 · 2 comments
Assignees
Labels
cleanup Code/comment cleanup: Low Priority complex Expected to be a complex issue

Comments

@tp-pbritt-nuc
Copy link

These isotopes have half lives greater than 10% off from a proprietary dataset developed from ENDF 7.1 compared with what's stored in ARMI nuclideBases.

hl_ratios.csv

@sombrereau sombrereau added cleanup Code/comment cleanup: Low Priority complex Expected to be a complex issue labels Apr 4, 2024
@sombrereau
Copy link
Contributor

@sombrereau -- is interested in this

@john-science john-science self-assigned this Apr 5, 2024
@john-science
Copy link
Member

My solution for this is to allow users to set which nuclide data source they want to use. It is strange that ARMI enforces one data set.

But the nuclide data is currently global, so the the order of operations to solve this ticket is:

  1. Move Global Nuclides out of the global scope
  2. New Setting to swap in different nuclide data

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Code/comment cleanup: Low Priority complex Expected to be a complex issue
Projects
None yet
Development

No branches or pull requests

3 participants