Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Settings validation for the versions setting #1675

Open
albeanth opened this issue Apr 2, 2024 · 0 comments
Open

Settings validation for the versions setting #1675

albeanth opened this issue Apr 2, 2024 · 0 comments
Labels
feature request Smaller user request

Comments

@albeanth
Copy link
Member

albeanth commented Apr 2, 2024

Background from #1234 (comment)

@albeanth -- I think there is definitely utility in having the version number stored on the database in addition to the stdout (an example use case being where a database was created with one version and then used in a restart calculation using a different version). But I think this information should may not come from the settings file, as its current set up can cause confusion (unless we add some sort of validation, or something).
...
We enable a settings validation on the versions setting where if the version listed in the setting differs from the venv, the user is alerted and made aware of the ramifications.
...
We enable a settings validation on the versions setting where if the version listed in the setting differs from the venv, the user is alerted and made aware of the ramifications.
...
@keckler -- in addition to his later thought that the version used in the initial run should be checked against the current version during restart cases.

Summary of proposed changes:

  1. Standard Run --> Enable settings validation step for when the versions setting differs from the currently activated venv.
  2. Restart Run --> Enable settings validation step for when the versions setting differs from either the currently activated venv and/or the database being loaded.

Questions:

  1. Currently, the behavior for when the versions settings is not provided is that it becomes "uncontrolled". Should the settings validation get skipped for this case?
  2. Do we enable the proposed changes for ARMI plugins as well? Or just ARMI?
@john-science john-science added the feature request Smaller user request label Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Smaller user request
Projects
None yet
Development

No branches or pull requests

2 participants