You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This is a big, complex change that will have to be done in phases.
It is an unfortunate fluke of history that ARMI's database class is called Database3. This was meant to be a temporary name used during a transition.
But, obviously, this is a big, API-breaking change that will cause a ton of (trivial) code changes in ARMI and downstream. So, I would suggest a long, gradual transition:
Move database3.py to database.py, but create the stub file below in a new database3.py.
Slowly transition all code in ARMI and downstream to use Database (without the "3").
Eventually, add a DeprecationWarning in Database3.py
It is an unfortunate fluke of history that ARMI's database class is called
Database3
. This was meant to be a temporary name used during a transition.But, obviously, this is a big, API-breaking change that will cause a ton of (trivial) code changes in ARMI and downstream. So, I would suggest a long, gradual transition:
database3.py
todatabase.py
, but create the stub file below in a newdatabase3.py
.Database
(without the "3").DeprecationWarning
inDatabase3.py
Database3
from ARMI.Suggested stub file to ease our transition:
The text was updated successfully, but these errors were encountered: