Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move all plotting functions into the utils plotting modules #1672

Open
8 tasks
john-science opened this issue Mar 29, 2024 · 0 comments
Open
8 tasks

Move all plotting functions into the utils plotting modules #1672

john-science opened this issue Mar 29, 2024 · 0 comments
Labels
architecture Issues related to big picture system architecture cleanup Code/comment cleanup: Low Priority

Comments

@john-science
Copy link
Member

ARMI has several plotting tools scattered throughout the codebase:

  • armi/bookkeeping/report/newReports.py : def plot
  • armi/nuclearDataIO/xsNuclides.py : def plotScatterMatrix
  • armi/nuclearDataIO/xsNuclides.py : def plotCompareScatterMatrix
  • armi/reactor/blocks.py : def plotFlux
  • armi/reactor/converters/blockConverters.py : def plotConvertedBlock
  • armi/reactor/converters/geometryConverters.py : def plotConvertedReactor
  • armi/reactor/converters/uniformMesh.py : def plotConvertedReactor
  • armi/utils/__init__.py : def plotMatrix

These should be moved into one of our plotting modules

  • armi/utils/plotting.py
  • armi/utils/reportPlotting.py

If it helps speed things up, we can preserve the current API by moving the the potting functions to utils/, and then just importing them in the modules where they are now.

@john-science john-science added architecture Issues related to big picture system architecture cleanup Code/comment cleanup: Low Priority labels Mar 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
architecture Issues related to big picture system architecture cleanup Code/comment cleanup: Low Priority
Projects
None yet
Development

No branches or pull requests

1 participant