Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redesign the ARMI Migration Scripts #1657

Open
john-science opened this issue Mar 4, 2024 · 0 comments
Open

Redesign the ARMI Migration Scripts #1657

john-science opened this issue Mar 4, 2024 · 0 comments
Assignees
Labels
architecture Issues related to big picture system architecture

Comments

@john-science
Copy link
Member

ARMI has some migration scripts from the dawn of time. But after a couple of years of trying, I can't find any examples of these old databases to test and make sure these scripts actually work. (I had to delete a couple that were overtly broken at some point.)

Also, these scripts are fundamentally untestable without example databases to test them on.

For the scripts to remain useful, we need them tested via CI so we can see when they go stale.

My current thinking:

  1. Delete the current scripts.
    a. Worry about the future, not the past.
  2. Add a new script (if necessary) every time ARMI releases a new, official version.
  3. Ensure the scripts are fully unit-tested, or they don't count.

What I haven't figured out yet is:

  • The scripts are currently importable in ARMI. Should they be part of the standard import armi namespace? This seems, I guess, convenient. But I've also never seen migration scripts importable as part of a project. They are usually their own directory of helpful tools.
@john-science john-science added the architecture Issues related to big picture system architecture label Mar 4, 2024
@john-science john-science self-assigned this Mar 4, 2024
@john-science john-science changed the title Top-Level Redesign of the ARMI Migration Scripts Redesign the ARMI Migration Scripts Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
architecture Issues related to big picture system architecture
Projects
None yet
Development

No branches or pull requests

1 participant