Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused rotationDegreesCCW argument #1623

Open
albeanth opened this issue Jan 25, 2024 · 1 comment
Open

Remove unused rotationDegreesCCW argument #1623

albeanth opened this issue Jan 25, 2024 · 1 comment
Labels
cleanup Code/comment cleanup: Low Priority good first issue Good for newcomers help wanted Extra attention is needed low priority

Comments

@albeanth
Copy link
Member

albeanth commented Jan 25, 2024 •
edited

While doing a review for #1619, I found that the argument rotationDegreesCCW is unused -- and I don't see any downstream projects that use it. So I think it's ripe for removal.

armi/armi/reactor/blocks.py

Line 597 in 3d49274

def coords(self, rotationDegreesCCW=0.0):

armi/armi/reactor/blocks.py

Line 1623 in 3d49274

def coords(self, rotationDegreesCCW=0.0):

@albeanth albeanth added the cleanup Code/comment cleanup: Low Priority label Jan 25, 2024
@albeanth albeanth changed the title Remove unused arguments Remove unused rotationDegreesCCW argument Jan 25, 2024
@john-science john-science added help wanted Extra attention is needed good first issue Good for newcomers low priority labels Jan 25, 2024
@john-science
Copy link
Member

I checked downstream, and I can confirm that no one is using this argument. This should is safe to remove.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cleanup Code/comment cleanup: Low Priority good first issue Good for newcomers help wanted Extra attention is needed low priority
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@john-science @albeanth