Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source block for converter is overwritten #1551

Open
albeanth opened this issue Dec 14, 2023 · 0 comments
Open

Source block for converter is overwritten #1551

albeanth opened this issue Dec 14, 2023 · 0 comments
Labels
cleanup Code/comment cleanup: Low Priority enhancement New feature or request

Comments

@albeanth
Copy link
Member

While homogenizing components into one another to create a homogenized block, the _sourceBlock (i.e., the original block to do the conversion on) is overwritten with the newBlock (i.e., the homogenized block). This seems like a potentially dangerous and unnecessary action. Is there a reason this is done? On the class constructor for BlockConverter (the parent class for the ComponentMerger class), there is even an instance attribute called convertedBlock. Why not set the homogenized block to that variable?

self._sourceBlock = newBlock

@albeanth albeanth added the help wanted Extra attention is needed label Dec 14, 2023
@john-science john-science added enhancement New feature or request cleanup Code/comment cleanup: Low Priority and removed help wanted Extra attention is needed labels Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Code/comment cleanup: Low Priority enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants