You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
While homogenizing components into one another to create a homogenized block, the _sourceBlock (i.e., the original block to do the conversion on) is overwritten with the newBlock (i.e., the homogenized block). This seems like a potentially dangerous and unnecessary action. Is there a reason this is done? On the class constructor for BlockConverter (the parent class for the ComponentMerger class), there is even an instance attribute called convertedBlock. Why not set the homogenized block to that variable?
While homogenizing components into one another to create a homogenized block, the
_sourceBlock
(i.e., the original block to do the conversion on) is overwritten with thenewBlock
(i.e., the homogenized block). This seems like a potentially dangerous and unnecessary action. Is there a reason this is done? On the class constructor forBlockConverter
(the parent class for theComponentMerger
class), there is even an instance attribute calledconvertedBlock
. Why not set the homogenized block to that variable?armi/armi/reactor/converters/blockConverters.py
Line 94 in 0977ee4
The text was updated successfully, but these errors were encountered: