Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can we remove FuelHandler.prepSearch? #1550

Open
john-science opened this issue Dec 13, 2023 · 3 comments
Open

Can we remove FuelHandler.prepSearch? #1550

john-science opened this issue Dec 13, 2023 · 3 comments
Labels
cleanup Code/comment cleanup: Low Priority good first issue Good for newcomers help wanted Extra attention is needed low priority

Comments

@john-science
Copy link
Member

It appears to me we should be able to remove the method FuelHandler.prepSearch():

def prepSearch(self, *args, **kwargs):

Because it hasn't done anything but raise a DeprecationWarning in years:

warnings.warn(
"`FuelHandler.prepSearch` is being deprecated from the framework. Please "
"change your fuel management input to call this method directly.",
DeprecationWarning,
)

I can find no downstream uses of this method either.

@john-science john-science added help wanted Extra attention is needed good first issue Good for newcomers cleanup Code/comment cleanup: Low Priority low priority labels Dec 13, 2023
@albeanth
Copy link
Member

Oh yeah. This hasn't been touched for a long time and just spits a DepracationWarning. I say time to remove the warning and just yank it!

@jakehader
Copy link
Member

This might impact downstream fuel handling scripts internally. Maybe note this to @onufer

@john-science
Copy link
Member Author

@onufer If there is some downstream code calling this and just getting a DeprecationWarning, let me fix that down stream code so it doesn't and we can safely delete this.

I guess the only other option is there are some downstream scripts which are sub-classing this and using it. That would be a different situation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Code/comment cleanup: Low Priority good first issue Good for newcomers help wanted Extra attention is needed low priority
Projects
None yet
Development

No branches or pull requests

3 participants