Update NHFLUX reader to read VARSRC files #1645
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test using the VARIANT NHFLUX file from the existing tests. I strip out the datasets that are not present in the VARSRC file and build the test based on that, rather than having to create a reference VARSRC file.
Nebbychadnezzar
requested review from
zachmprince
and removed request for
mgjarrett
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the change?
This PR adds a conditional processing of the 2D record in the NHFLUX binary file based on the value of the IWNHFL flag.
Why is the change being made?
The VARSRC binary file format is a subset of the NHFLUX binary file format. The reader currently has a minor bug in it that doesn't allow it to read a VARSRC file because it always assumes that the 2D record is present, which is not true for VARSRC files. This PR addresses the bug.
A new test has also been added to ensure that the VARSRC file format is considered as part of future code changes.
Checklist
doc/release/0.X.rst) are up-to-date with any important changes.docfolder.pyproject.toml.