You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
But they give people the assumption they can trust these assemblies have a shape, or the blocks inside them do. But obviously no.
I recommend that we override the superclass method Assembly.add() here to check the shape of the Blocks added to assemblies of these types. That will give users some trust, anyway, that instances of these classes are what you'd think at first glance.
The text was updated successfully, but these errors were encountered:
Right now, the classes
HexAssembly
andCartesianAssembly
are just empty slates:armi/armi/reactor/assemblies.py
Lines 1229 to 1237 in 8b9873c
armi/armi/reactor/assemblies.py
Lines 1240 to 1241 in 8b9873c
But they give people the assumption they can trust these assemblies have a shape, or the blocks inside them do. But obviously no.
I recommend that we override the superclass method
Assembly.add()
here to check the shape of the Blocks added to assemblies of these types. That will give users some trust, anyway, that instances of these classes are what you'd think at first glance.The text was updated successfully, but these errors were encountered: