Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

armi.utils.reportPlotting:plotReactorPerformance has out of date parameters #1450

Open
cbroman-usnctech opened this issue Oct 25, 2023 · 2 comments · May be fixed by #1451
Open

armi.utils.reportPlotting:plotReactorPerformance has out of date parameters #1450

cbroman-usnctech opened this issue Oct 25, 2023 · 2 comments · May be fixed by #1451
Labels
bug Something is wrong: Highest Priority cleanup Code/comment cleanup: Low Priority

Comments

@cbroman-usnctech
Copy link

cbroman-usnctech commented Oct 25, 2023 •
edited

The plotting utility function armi.utils.reportPlottings:plotReactorPerformance has an outdated Reactor parameter named eFuelCycleCost causing getHistory function to fail. On line 70.

    try:
        data = dbi.getHistory(
            reactor, params=["cycle", "time", "eFeedMT", "eSWU", "eFuelCycleCost"]
        )

plotReactorPerformance also has an input argument named history which defaults to None. This variable is passed to the function xsHistoryVsTime as a required parameter on line 117.

xsHistoryVsTime(reactor.name, history, buGroups, extension=extension)
@cbroman-usnctech cbroman-usnctech changed the title armi.utils.reportPlottings:plotReactorPerformance has out of date parameters armi.utils.reportPlotting:plotReactorPerformance has out of date parameters Oct 25, 2023
@john-science
Copy link
Member

@cbroman-usnctech I would just remove that one string from that line of code.

Do you want to open a PR for it, or should I?

@john-science john-science added bug Something is wrong: Highest Priority cleanup Code/comment cleanup: Low Priority labels Oct 25, 2023
@cbroman-usnctech
Copy link
Author

@john-science I can make a PR.

@cbroman-usnctech cbroman-usnctech linked a pull request Oct 25, 2023 that will close this issue
Open
8 tasks
@john-science john-science linked a pull request Jan 17, 2024 that will close this issue
Remove deprecated core param, fixing optional history. #1451
Open
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something is wrong: Highest Priority cleanup Code/comment cleanup: Low Priority
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove deprecated core param, fixing optional history. cbroman-usnctech/armi
2 participants
@john-science @cbroman-usnctech