add vault_update_policy_type parameter

[mark-00]

When changing the loadbalancer from external to internal the instance were not recreated and vault was unreachable

Add vault_update_policy_type parameter for the instance group so the type can be chanched to PROACTIVE as needed

Default value of the parameter is OPPORTUNISTIC to not change the default behavoir altought a PROACTIVE approach is problably better.

[comment-bot-dev]

Thanks for the PR! 🚀
✅ Lint checks have passed.

[mark-00]

Can you tell me what went wrong with the linting? I have no access to the see the details of the test

[onetwopunch]

Thanks for the PR! It seems lint is still failing on generating the docs. This can happen if you have a more recent version of the devtools container than Cloud Build is using. The one we're using in this repo is: gcr.io/cloud-foundation-cicd/cft/developer-tools:0.12.0 Is that the same one you have locally?

Additionally, once you have that container locally you can run make docker_test_lint which runs the same lint tests as Cloud Build so you can verify before pushing

[mark-00]

THis is in the makefile so that is the version I use

DOCKER_TAG_VERSION_DEVELOPER_TOOLS := 0
DOCKER_IMAGE_DEVELOPER_TOOLS := cft/developer-tools
REGISTRY_URL := gcr.io/cloud-foundation-cicd

[mark-00]

Nice. using 0.12.0 worked. All tests passed

[onetwopunch]

LGTM thanks for this PR!