Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix!: delete deprecated attribute authorized_gae_applications #240

Conversation

kam1kaze
Copy link
Contributor

Just delete the latest deprecated attribute related to First Generation instances. Fix #219

@google-cla
Copy link

google-cla bot commented Aug 20, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added the cla: no label Aug 20, 2021
@comment-bot-dev
Copy link

comment-bot-dev commented Aug 20, 2021

Thanks for the PR! 🚀
✅ Lint checks have passed.

@kam1kaze kam1kaze force-pushed the delete_authorized_gae_applications branch from 9d66296 to b2a5032 Compare August 20, 2021 15:29
@google-cla google-cla bot added cla: yes and removed cla: no labels Aug 20, 2021
Signed-off-by: Oleksii Kravchenko <oleksii.kravchenko@aspira.global>
@kam1kaze
Copy link
Contributor Author

I don't have access to Cloud Build logs, so I've no idea why terraform-google-sql-db--int-trigger test failed.

Copy link
Member

@bharathkkb bharathkkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kam1kaze it's due to #231 and not related to change

@bharathkkb bharathkkb changed the title fix: delete deprecated attribute authorized_gae_applications fix!: delete deprecated attribute authorized_gae_applications Aug 20, 2021
@bharathkkb bharathkkb merged commit d35b23c into terraform-google-modules:master Aug 20, 2021
@release-please release-please bot mentioned this pull request Aug 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Warning: Deprecated attribute: authorized_gae_applications
3 participants