Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creates random passwords for additional_users #236

Merged
merged 6 commits into from
Sep 10, 2021

Conversation

samcre
Copy link
Contributor

@samcre samcre commented Jul 29, 2021

For every Cloud SQL instance type, if additional_users.password it's
an empty string, the module will create a random password.

Also, adds an output to retrieve users and passwords from other
resources.

For every Cloud SQL instance type, if `additional_users.password` it's
an empty string, the module will create a random password.

Also, adds an output to retrieve users and passwords from other
resources.
@google-cla
Copy link

google-cla bot commented Jul 29, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added the cla: no label Jul 29, 2021
@comment-bot-dev
Copy link

comment-bot-dev commented Jul 29, 2021

Thanks for the PR! 🚀
✅ Lint checks have passed.

@google-cla
Copy link

google-cla bot commented Jul 29, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@samcre
Copy link
Contributor Author

samcre commented Jul 29, 2021

@googlebot I signed it!

@google-cla google-cla bot added cla: yes and removed cla: no labels Jul 29, 2021
@morgante
Copy link
Contributor

@samcre Please address the formatting issues.

@samcre
Copy link
Contributor Author

samcre commented Jul 30, 2021

@morgante I think I already did it, but terraform-google-sql-db--int-trigger is failing again, and I can't see what's going on with the build. 🤔

Copy link
Contributor

@morgante morgante left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this, just one nit.

modules/mssql/outputs.tf Show resolved Hide resolved
@morgante
Copy link
Contributor

@samcre Looks like the test failure is unrelated, you can ignore it.

@samcre
Copy link
Contributor Author

samcre commented Sep 10, 2021

@morgante Everything is OK? Should I make more changes?

@morgante morgante merged commit 94ef3de into terraform-google-modules:master Sep 10, 2021
@tfluehmann
Copy link

HI @samcre
Will this change overwrite existing passwords?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants