Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: extended the postgresql module to accept IAM users and services accounts #218

Merged
merged 7 commits into from
May 19, 2021
Merged

feat: extended the postgresql module to accept IAM users and services accounts #218

merged 7 commits into from
May 19, 2021

Conversation

g-awmalik
Copy link
Contributor

The postgresql module has been extended to accept IAM users (both Google IDs and Service Accounts) as valid users to the database. In addition to that, this PR contains an example for provisioning IAM users and a corresponding integration test.

@comment-bot-dev
Copy link

comment-bot-dev commented May 12, 2021 •
edited

Thanks for the PR! 🚀
✅ Lint checks have passed.

bharathkkb
bharathkkb reviewed May 13, 2021
View reviewed changes
Copy link
Member

@bharathkkb bharathkkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @g-awmalik

modules/postgresql/main.tf Outdated Show resolved Hide resolved
test/integration/postgresql-public-iam/controls/pg.rb Show resolved Hide resolved
@g-awmalik
Copy link
Contributor Author

@bharathkkb - please take a look at the changes now. Thnx.

bharathkkb
bharathkkb reviewed May 17, 2021
View reviewed changes
Copy link
Member

@bharathkkb bharathkkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM

/cc @morgante for another look

examples/postgresql-public-iam/main.tf Outdated Show resolved Hide resolved
modules/postgresql/main.tf Outdated Show resolved Hide resolved
@bharathkkb bharathkkb changed the title feat!: extended the postgresql module to accept IAM users and services accounts feat: extended the postgresql module to accept IAM users and services accounts May 19, 2021
@bharathkkb bharathkkb merged commit 4c0472e into terraform-google-modules:master May 19, 2021
@bharathkkb bharathkkb mentioned this pull request May 19, 2021
Closed
@g-awmalik g-awmalik deleted the feature/users-iam branch May 19, 2021 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@morgante morgante morgante left review comments

@bharathkkb bharathkkb bharathkkb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@g-awmalik @comment-bot-dev @morgante @bharathkkb