Added support for setting transaction_log_retention_days, retained_backups, and retention_unit to backup_configuration.

[tjokimie]

Add support for transaction_log_retention_days and backup_retention_settings.

Closes #199.

[morgante]

Please check the contributing guide and ensure tests pass: https://github.com/terraform-google-modules/terraform-google-sql-db/blob/master/CONTRIBUTING.md

[schirayu]

@tjokimie - are you still working on this PR?

[waqas105]

Anyupdate on this request? i tried the code not wokring for me.

[morgante]

@waqas105 The PR needs to be rebased and edited to make sure tests pass.

[comment-bot-dev]

Thanks for the PR! 🚀
✅ Lint checks have passed.

[tjokimie]

@waqas105 The PR needs to be rebased and edited to make sure tests pass.

@morgante Sorry, finishing this took quite a bit longer than I anticipated. I fixed the issue, rebased the PR, updated the examples and added some tests.

I run the tests locally but I couldn't figure out what triggered this one to fail. All the other tests are passing.

×  Postgres SQL pubic instance has just one assigned IP address

     expected: 1
          got: 2

     (compared using ==)

The ipAddresses block seems to be [{"ipAddress"=>"34.134.242.179", "type"=>"PRIMARY"}, {"ipAddress"=>"35.239.168.247", "type"=>"OUTGOING"}] so there is additional OUTGOING IP address added. Do you have any ideas what could cause this?

[morgante]

/gcbrun

[morgante]

Thanks for the rebase and apologies for the churn. You can ignore the test failure as it looks unrelated.

[morgante]

I don't think we need to nest this. Let's just collapse to the backup_configuration level:

backup_configuration = {
    enabled                        = true
    start_time                     = "20:55"
    location                       = null
    point_in_time_recovery_enabled = false
    transaction_log_retention_days = null
    retained_backups = 365
    retention_unit = "COUNT"
}

[tjokimie]

@morgante Good idea, updated in e89c589 👍

[tjokimie]

Rebased with master again.

[morgante]

Thanks, test failure is unrelated.