Read replica deletion protection #155
Conversation
…ead replica db instances.
…ead replica db instances.
…' into read-replica-deletion-protection
|
I thought it would be helpful, usually replicas aren't as important to keep up. Could set read_replica_deletion_protection to false always, then only change deletion_protection when changing the default db. I'm open to using the existing variable or setting to false always, just let me know the preference and I can make the change. Currently can't bring down replicas with TF so this is blocking for us. |
|
Got it, that's fine. Can you please get tests passing, as per the contributing guide? |
…/Remesh/terraform-google-sql-db into read-replica-deletion-protection
|
@morgante Tests are now passing, sorry this took so long, had to fix things from previous merged PR's. |
modules/postgresql/variables.tf
Outdated
| variable "read_replica_deletion_protection" { | ||
| description = "Used to block Terraform from deleting replica SQL Instances." | ||
| type = bool | ||
| default = true |
There was a problem hiding this comment.
I'm wondering if this should be false by default? Deleting read replicas isn't as dangerous as deleting the primary.
There was a problem hiding this comment.
Updated, also removed read_replica_deletion_protection = false from the examples
This PR adds a variable to manage read replica deletion protection.