feat: Grant pull subscription permissions for external service account #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR! 🚀 |
|
I'm not sure we want to include this in the module directly. |
|
Yes, it's really not useful for granting permissions inside one project or administration domain. |
morgante
reviewed
Apr 6, 2021
README.md
Outdated
| filter = "attributes.domain = \"com\"" // optional | ||
| enable_message_ordering = true // optional | ||
| service_account = "service2@project2.iam.gserviceaccount.com" // optional | ||
| service_account_viewer_role = true // optional |
There was a problem hiding this comment.
Could we simply always set this? I'm not sure we need the flexibility.
morgante
approved these changes
Apr 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is useful to grant permissions for the service account that will subscribe to that pull_subscription just after creating it.
Especially if granting access to the service account from another project.
Also as Kafka-connect needs additional
roles/pubsub.viewerrole for subscribing to the topic,service_account_viewer_roleswitch is provided.