Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: release 10.0.0 #496

Merged
merged 2 commits into from
Dec 16, 2020
Merged

chore: release 10.0.0 #496

merged 2 commits into from
Dec 16, 2020

Conversation

release-please[bot]
Copy link
Contributor

@release-please release-please bot commented Nov 10, 2020

🤖 I have created a release *beep* *boop*

10.0.0 (2020-12-16)

⚠ BREAKING CHANGES

  • Minimum Terraform version increased to 0.13.
  • All null_resources for executing gcloud scripts have been removed. See the upgrade guide for details.

Features

  • add TF 0.13 constraint and module attribution (#513) (f6df34c)
  • support activate_api_identities in shared_vpc submodule (#509) (8c5698c)
  • terraform: Add support Terraform 0.14 by bumping version constraint (#505) (8c01c41)

Bug Fixes

  • Add billingbudgets.googleapis.com to precondition script. (#493) (f9b53c3)
  • Add count variable to does not create the resource when value is keep (#498) (a3deaad)
  • Add shared_vpc features back to rood module (#446) (0a6b9b9)
  • All dependencies on gcloud have been removed. (#491) (5886a4e)
  • readme link to svpc example (#515) (ce1d46e)
  • Remove whitespace in test/setup-sa (#495) (6d90ff3)
  • rename shared_vpc submodule to svpc_service_project(#517) (86819d7)
  • Support passing service project number to shared_vpc_access to be Terraform 0.13 compatible (#500) (825d07b)

This PR was generated with Release Please.

@downwithwindoze
Copy link

Testing both the current master and branch v10.0.0 I find that using default_service_account = "keep" consistently throws this error:

Error: expected action to be one of [DEPRIVILEGE DELETE DISABLE], got KEEP

  on .terraform/modules/project/modules/core_project_factory/main.tf line 121, in resource "google_project_default_service_accounts" "default_service_accounts":
 121:   action         = upper(var.default_service_account)

I think you need to set count = upper(var.default_service_accounts)=="KEEP" ? 0 : 1 on resource "google_project_default_service_accounts" "default_service_accounts"

@bharathkkb
Copy link
Member

@downwithwindoze thanks for the report. Tracking here: #497

Copy link
Contributor

@morgante morgante left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thiagonache
Copy link
Contributor

thiagonache commented Dec 2, 2020

@morgante PR 7768 is merged. Do you think we can get this release until tomorrow? I'm going to talk about this module and I'd like to show the version without gcloud if possible 😄
Since the PR is merged I don't see any problem releasing 10.0.0 now, do you? Or maybe a pre-release version?

@morgante
Copy link
Contributor

morgante commented Dec 3, 2020

@thiagonache Since we will need to set a version constraint I'm going to hold off on release until we can do that. Can you simply point to master for your talk though?

@thiagonache
Copy link
Contributor

thiagonache commented Dec 3, 2020

@thiagonache Since we will need to set a version constraint I'm going to hold off on release until we can do that. Can you simply point to master for your talk though?

I could but I'll enforce that we should use immutable infrastructure by setting tags, etc. and that would "violate" what I'm talking about.... but I can handle that in another manner. I just thought that I can use my own github or use the latest version on the demo and just show the code changes of the new version

@bharathkkb bharathkkb mentioned this pull request Dec 3, 2020
@release-please release-please bot force-pushed the release-v10.0.0 branch 2 times, most recently from 5e435f6 to e5504e6 Compare December 4, 2020 19:32
@morgante
Copy link
Contributor

morgante commented Dec 7, 2020

@thiagonache Could you switch to REVERT_AND_IGNORE_FAILURE and pin minimum provider version to v3.50.0?

@thiagonache
Copy link
Contributor

I've been busy. It took me a while to be able to spare some time.

There it is #511

@bharathkkb
Copy link
Member

@morgante Were you thinking of dropping support for 0.12 with this or next major?

@morgante
Copy link
Contributor

morgante commented Dec 9, 2020

@bharathkkb We can do it now.

@xingao267
Copy link
Member

The last item on the check list "Switch to REVERT_AND_IGNORE_FAILURE and pin minimum provider version to v3.50.0" seems done in #511. Any chance we can release this major soon?

@xingao267
Copy link
Member

Sent #516 to fix the lint issue here.

@bharathkkb
Copy link
Member

we should also do this #463 for clarity

@xingao267
Copy link
Member

we should also do this #463 for clarity

Is it being worked on? We kind of need the next version of Project Factory to be released soon to use the activate API identities feature in shared_vpc module and also Terraform 0.13 support.

@thiagonache
Copy link
Contributor

we should also do this #463 for clarity

Is it being worked on? We kind of need the next version of Project Factory to be released soon to use the activate API identities feature in shared_vpc module and also Terraform 0.13 support.

I can work on it in the next days or if you want to take it, it's okay

@xingao267
Copy link
Member

we should also do this #463 for clarity

Is it being worked on? We kind of need the next version of Project Factory to be released soon to use the activate API identities feature in shared_vpc module and also Terraform 0.13 support.

I can work on it in the next days or if you want to take it, it's okay

I'm not familiar with the context and discussions behind this issue. Will leave this to you @thiagonache. Thanks!

@ChandranshuRao14
Copy link
Contributor

I can work on it in the next days or if you want to take it, it's okay

@thiagonache mind if I take this? My team is currently blocked until 10.0.0 is released so I can get this change in today

@thiagonache
Copy link
Contributor

thiagonache commented Dec 14, 2020 via email

@release-please release-please bot force-pushed the release-v10.0.0 branch 2 times, most recently from d27c133 to c948727 Compare December 15, 2020 20:43
@morgante
Copy link
Contributor

@thiagonache @bharathkkb @ChandranshuRao14 Does anyone have bandwidth to write an upgrade guide?

@bharathkkb
Copy link
Member

@thiagonache has written the initial version, will work with @ChandranshuRao14 to include changes from the rename

@morgante morgante merged commit d3f09e2 into master Dec 16, 2020
@morgante morgante deleted the release-v10.0.0 branch December 16, 2020 16:07
xingao267 pushed a commit that referenced this pull request Dec 16, 2020
* chore: release 10.0.0

* Update CHANGELOG.md

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Co-authored-by: Morgante Pell <morgantep@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants