Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option for skipping the gcloud CLI download #393

Merged

Conversation

MajorBreakfast
Copy link
Contributor

Adds ability to skip the downloading of the gcloud CLI. Exposing this functionality is important to us because:

  • the download functionality adds a lot of unnecessary overhead when running in our ci pipeline which runs in a container image with gcloud pre-installed
  • the resources it adds to the terraform plan make the plan harder to read
  • it seems to scale not so well with the amount of projects because the gcloud cli is installed once for every module instance instead of once overall

Similar to #369. However, that PR semms to contain other unreleated changes

@MajorBreakfast
Copy link
Contributor Author

CI failed, but I don't have the permissions to see what went wront

@bharathkkb
Copy link
Member

@MajorBreakfast looks like it failed the linting step due to document generation. please run make docker_generate_docs and to test the lint step locally make docker_test_lint.

@MajorBreakfast
Copy link
Contributor Author

All green now. @bharathkkb Thanks for the instructions!

@morgante
Copy link
Contributor

Thanks for handling this!

@morgante morgante merged commit a534603 into terraform-google-modules:master Mar 17, 2020
@thesuperzapper
Copy link
Contributor

@MajorBreakfast, even with this change, I am still getting my changes polluted like #391.

If we are assuming gcloud will be in the PATH, cant we remove gcloud_bin_abs_path from the triggers of null_resource.run_command?

@MajorBreakfast
Copy link
Contributor Author

MajorBreakfast commented Apr 3, 2020

@thesuperzapper The usage of terraform-google-gcloud seems to create two problems. I've created an issue that summarizes them both here #396

@adrian-gierakowski
Copy link
Contributor

adrian-gierakowski commented Apr 15, 2020

@MajorBreakfast is this just a placeholder for something that will be implemented in the future? terraform still seems to try to download gcloud even with skip_gcloud_download = true

looks like it's actually getting stuck when downloading https://github.com/terraform-google-modules/terraform-google-gcloud which is massive due to binaries included in the repo (as mentioned here: terraform-google-modules/terraform-google-gcloud#37

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants