-
Notifications
You must be signed in to change notification settings - Fork 533
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option for skipping the gcloud CLI download #393
Add option for skipping the gcloud CLI download #393
Conversation
CI failed, but I don't have the permissions to see what went wront |
@MajorBreakfast looks like it failed the linting step due to document generation. please run make docker_generate_docs and to test the lint step locally make docker_test_lint. |
715b652
to
3a1ee3d
Compare
All green now. @bharathkkb Thanks for the instructions! |
Thanks for handling this! |
@MajorBreakfast, even with this change, I am still getting my changes polluted like #391. If we are assuming |
@thesuperzapper The usage of terraform-google-gcloud seems to create two problems. I've created an issue that summarizes them both here #396 |
@MajorBreakfast looks like it's actually getting stuck when downloading https://github.com/terraform-google-modules/terraform-google-gcloud which is massive due to binaries included in the repo (as mentioned here: terraform-google-modules/terraform-google-gcloud#37 |
Adds ability to skip the downloading of the gcloud CLI. Exposing this functionality is important to us because:
Similar to #369. However, that PR semms to contain other unreleated changes