Add dependency on service enablement.

[mattcary]

Adds a dependency on project services to the output project id and
number. This prevents a race for using a robot account based on the
project id or number, as the robot accounts can be created only when
the service enabling is finished.

Fixes #386

[mattcary]

Fixes #386

[mattcary]

I've run make docker_test_integration manually and everything was ok (except for the destroy step).

[morgante]

Looks good! Just need to format (so make docker_test_lint doesn't complain):

-  depends_on = [ module.project_services ]
+  depends_on = [module.project_services]
 }
 
 output "project_number" {
-  value = google_project.main.number
-  depends_on = [ module.project_services ]
+  value      = google_project.main.number
+  depends_on = [module.project_services]
 }

[mattcary]

Thanks, done.

Should I try to add anything to testing? It looks like the full test fixture already enables the container services and mucks about with service accounts, so I could just add a project iam binding there.

But I'm not sure if you want to keep the tests more focused or whatever.

[morgante]

Adding an additional IAM grant to the full fixture should be sufficient (and adding a test that verify it was granted).

[mattcary]

Super. I'll do that and ping here when finished.

[mattcary]

As discussed offline, I couldn't add tests to the full fixture as it isn't working. I added them to minimal instead (making it somewhat less minimal, but oh well...).

LMK if this isn't what you had in mind.

Thanks!

[morgante]

Thanks! This approach looks fine, please just run make generate_docs to regenerate docs and make Cloud Build stop complaining.

[mattcary]

Done, thanks.

I can't see the cloud build output or errors, digging into the details I don't have a cloudbuild.builds.get permission. Is there something to be added to, or are there any other errors in the build?