Add use_tf_var_google_credentials_env_var variable #377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
morgante
suggested changes
Feb 21, 2020
|
Thanks for the review! I've added it to the variant modules as requested |
morgante
suggested changes
Feb 26, 2020
|
@morgante Docs updated as requested. |
morgante
suggested changes
Mar 2, 2020
modules/core_project_factory/main.tf
Outdated
| @@ -185,7 +186,8 @@ module "gcloud_deprivilege" { | |||
| source = "terraform-google-modules/gcloud/google" | |||
| version = "~> 0.5.0" | |||
|
|
|||
| enabled = var.default_service_account == "deprivilege" | |||
| enabled = var.default_service_account == "deprivilege" | |||
| use_tf_google_credentials_env_var = use_tf_google_credentials_env_var | |||
There was a problem hiding this comment.
Suggested change
| use_tf_google_credentials_env_var = use_tf_google_credentials_env_var | |
| use_tf_google_credentials_env_var = var.use_tf_google_credentials_env_var |
modules/core_project_factory/main.tf
Outdated
| @@ -210,7 +212,8 @@ module "gcloud_disable" { | |||
| source = "terraform-google-modules/gcloud/google" | |||
| version = "~> 0.5.0" | |||
|
|
|||
| enabled = var.default_service_account == "disable" | |||
| enabled = var.default_service_account == "disable" | |||
| use_tf_google_credentials_env_var = use_tf_google_credentials_env_var | |||
There was a problem hiding this comment.
Suggested change
| use_tf_google_credentials_env_var = use_tf_google_credentials_env_var | |
| use_tf_google_credentials_env_var = var.use_tf_google_credentials_env_var |
variables.tf
Outdated
| @@ -179,6 +179,12 @@ variable "pip_executable_path" { | |||
| default = "pip3" | |||
| } | |||
|
|
|||
| variable "use_tf_google_credentials_env_var" { | |||
| description = "Use GOOGLE_CREDENTIALS environment variable to run gcloud auth activate-service-account with." | |||
| type = string | |||
There was a problem hiding this comment.
Suggested change
| type = string | |
| type = bool |
|
@morgante Thanks for the thorough review, I have updated the reference and variable type now. |
morgante
approved these changes
Mar 3, 2020
|
Thanks for adding this and being patient with the review process. |
This was referenced Aug 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #380.