Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Firewall rule fails open if no sources specified #36

Open
DeanBrunt opened this issue Sep 4, 2020 · 3 comments
Open

Firewall rule fails open if no sources specified #36

DeanBrunt opened this issue Sep 4, 2020 · 3 comments
Labels
enhancement New feature or request P2 high priority issues triaged Scoped and ready for work

Comments

@DeanBrunt
Copy link

The firewall for this module fails open (to range 0.0.0.0/0) if no sources are specified.

This is concerning as it leaves unaware users of this module one step away from opening their load balancer to traffic from anywhere, possibly without realising.
@morgante
Copy link
Contributor

morgante commented Sep 4, 2020

We should add a check that that some source type is required.

@morgante morgante added enhancement New feature or request P2 high priority issues triaged Scoped and ready for work labels Sep 4, 2020
@DeanBrunt
Copy link
Author

This looks to be represented upstream as well: hashicorp/terraform-provider-google#6789

@devodev
Copy link

devodev commented Jan 3, 2024

I got stung by this today :(
Still relevant in latest version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request P2 high priority issues triaged Scoped and ready for work
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@morgante @DeanBrunt @devodev