feat!: add gpu node autoscaling support (#807) #944
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* add gpu node autoscaling support for top level module * add gpu node autoscaling support for beta-private-cluster module
JamesTimms
requested review from
bharathkkb,
Jberlinsky and
a team
as code owners
|
Thanks for the PR! 🚀 |
added 3 commits
June 30, 2021 16:47
…google-modules#807) * add gpu node autoscaling support for all modules
…google-modules#807) * updater example/node_pool cluster_autoscaling var to work with gpu_resources
…google-modules#807) * fix example/node_pool formatting error
bharathkkb
requested changes
Jul 1, 2021
autogen/main/variables.tf.tmpl
Outdated
Comment on lines
253
to
254
| max_memory_gb = number | ||
| gpu_resources = list(object({ |
There was a problem hiding this comment.
the tf fmt lint error is possibly due to this
Suggested change
| max_memory_gb = number | |
| gpu_resources = list(object({ | |
| max_memory_gb = number | |
| gpu_resources = list(object({ |
There was a problem hiding this comment.
I tried that originally but no luck. I've now moved the object all on one line like other object definitions.
bharathkkb
changed the title
|
We will also need a small upgrade guide like this showing gpu_resources set to |
…google-modules#807) * Format gpu_resource to meet linter requirements * Update examples/node_pool/
…google-modules#807) * Add v16.0 upgrade guide * Update node_pool test to specify `gpu_resources`
bharathkkb
approved these changes
Jul 6, 2021
…google-modules#807) * updates upgrade guide Co-authored-by: Bharath KKB <bharathkrishnakb@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I haven't added this for any other modules yet as I only need it for
beta-private-cluster. If you're happy with the change I'll make it for other modules where it's needed.edit: I've now read the
CONTRIBUTING.mdguide and have updated my PR 🔨